-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes) #16984
Open
snehashisp
wants to merge
16
commits into
apache:trunk
Choose a base branch
from
snehashisp:multiversioning
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+366
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snehashisp
changed the title
[WIP] Connect Multiversion Support (Plugin Loading Isolation Changes) (KIP-891)
[WIP] KIP-891: Connect Multiversion Support (Base PR with Plugin Loading Isolation Changes)
Nov 10, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is one of a set of PRs for KIP-891. The list of total PRs given below all build one the previous one in the list. They can be reviewed individually, or if the complete set of changes is preferrable, please refer to the last PR.
This is PR#1 and contains changes to connects plugin loading package. It contains the set of changes to load versioned plugins based on maven versioning as described in the KIP and exposes a set of public methods for use in the other components of this KIP.
Additional PRs for changes to status endpoint showing currently running version and JMX metrics are underway and need not block any feedback for the existing PRs. Some manual testing has been done and extensive tests will soon be added.
Committer Checklist (excluded from commit message)